Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New setup_requires #105

Closed
williamjamir opened this issue Oct 23, 2017 · 4 comments
Closed

New setup_requires #105

williamjamir opened this issue Oct 23, 2017 · 4 comments

Comments

@williamjamir
Copy link
Contributor

@williamjamir williamjamir commented Oct 23, 2017

Hello,

With the new release the setup.py now requires installing 'gease'.

I didn't understand this requirement, for what I understood this package is a command line interface for make releases, am I right?

@chfw
Copy link
Member

@chfw chfw commented Oct 23, 2017

Hmm... for publishing, it uses gease, which make my life easier as all commands are integrated but I can see it causes some problem for the end user as gease is of no use if not the maintainer. Let me look into this.

@chfw
Copy link
Member

@chfw chfw commented Oct 23, 2017

the integration equals:

python setup.py publish = python setup.py sdist bdist_wheel upad -r pypi + github release this version

@williamjamir
Copy link
Contributor Author

@williamjamir williamjamir commented Oct 23, 2017

Just giving some background information, I'm including the pyexcel-* packages on conda-forge to be installed with conda, so I need to build the package to be able to include in the repository.

So my point is, the package gease doesn't look like a real build dependency for pyexcel, even though it makes the life of the maintainer easier.
Could you perhaps install this package separately, without enforcing dependencies in the package?

@chfw
Copy link
Member

@chfw chfw commented Oct 23, 2017

OK. I will remove it from setup require and make gease as optional in setup.py. with or without it, setup.py will function.

chfw added a commit to pyexcel/pyexcel-io that referenced this issue Oct 23, 2017
@chfw chfw closed this in cad7501 Oct 23, 2017
chfw added a commit that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-ods that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-ods3 that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-xls that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-xlsx that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-odsr that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-xlsxw that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-htmlr that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel-webwares/pyexcel-webio that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel-webwares/pyramid-excel that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel-webwares/django-excel that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel-webwares/Flask-Excel that referenced this issue Oct 23, 2017
chfw added a commit to moremoban/pypi-mobans that referenced this issue Oct 23, 2017
chfw added a commit to pyexcel/pyexcel-ods3 that referenced this issue Oct 3, 2020
*  reproduce #12

* release 0.5.0 🥚 🎡

* 🤝 take latest code from setupmobans and release 0.5.1 🥚 🎡, which carries LICENSE file, pyexcel/pyexcel#103

* 🥚 🎡 release 0.5.2. related to pyexcel/pyexcel#105

*  refuse to write value that will not persist. pyexcel/pyexcel-ods#30

* 🔨 sort import list, code format using black, supreme pep 8 formatter. and update moban to use latest moban 0.3.4

*  use pyexcel-io 0.5.10

* 🔥 replace python 2.6 3.3 with python 3.7-dev

* 🥚 🎡 release 0.5.3

* 🔨 minor update

* 🤝 apply common templates from pyexcel mobans. moremoban/moban#348

* 👕 update coding style

* 📰 add missing files

* 📚 pass moban stage

* 🔥 no longer to generate test files

*  respect moban

* 👕 update format.sh

* 🤝 synchronize the organisational meta data

* 🚀 github actions for moban, pypi release and automatically extract contributors

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 🤝 update project meta

* 🤝 update project meta data

* 🎉 new style ods reader

* 🎉 new style ods writer

* 📚 update changelog

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💄 update coding style

* 💚 use pyexcel-io v0.6.0 in test

Co-authored-by: chfw <chfw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants