New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set membership test to run faster in python2 #115

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@arunkumar-ra
Contributor

arunkumar-ra commented Feb 20, 2018

Fix to this issue: #114
PS. I haven't tested the fix

@codecov-io

This comment has been minimized.

codecov-io commented Feb 20, 2018

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          94       94           
  Lines        6197     6197           
=======================================
  Hits         6121     6121           
  Misses         76       76
Impacted Files Coverage Δ
pyexcel/internal/sheets/matrix.py 99.04% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b8557...42033f3. Read the comment docs.

@chfw

This comment has been minimized.

Member

chfw commented Feb 23, 2018

Thanks for getting it started. I will append the test cases.

@chfw chfw merged commit f8d00a5 into pyexcel:master Feb 23, 2018

3 checks passed

codecov/patch 100% of diff hit (target 98.77%)
Details
codecov/project 98.77% (+0%) compared to 15b8557
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

chfw added a commit that referenced this pull request Feb 23, 2018

chfw added a commit that referenced this pull request Feb 23, 2018

chfw added a commit that referenced this pull request Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment