Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading and trailing whitespace for names #214

Merged
merged 1 commit into from Jul 7, 2020
Merged

remove leading and trailing whitespace for names #214

merged 1 commit into from Jul 7, 2020

Conversation

mathsyouth
Copy link
Contributor

@mathsyouth mathsyouth commented Jul 3, 2020

The names will be used as keys for returned dictionary. If keys are not
striped and user inputs striped keys because excel shows unseen
whitespace, it will cause an error.

The names will be used as keys for returned dictionary. If keys are not
striped and user inputs striped keys because excel shows unseen
whitespace, it will cause a error.
@chfw chfw merged commit a86ecfa into pyexcel:dev Jul 7, 2020
1 check failed
@chfw
Copy link
Member

chfw commented Jul 7, 2020

thanks! it makes sense.

@chfw
Copy link
Member

chfw commented Jul 7, 2020

would you like to make a unit test to protect your modification? i.e.: just in case I accidentally would remove your improvement in the future.

@mathsyouth
Copy link
Contributor Author

mathsyouth commented Jul 11, 2020

I want to make a unit test for the modification. However, after installing dependent libraries according to Developer's guide, I launched your tests like this: make. All of your tests don't run. Please see the details in the attached. Thanks!
output.txt

@chfw
Copy link
Member

chfw commented Jul 18, 2020

@mathsyouth could you please have a look again? it has been fixed.

@chfw
Copy link
Member

chfw commented Jul 18, 2020

Please update change log for your PR too.

@mathsyouth mathsyouth mentioned this pull request Jul 31, 2020
10 tasks
mathsyouth added a commit to mathsyouth/pyexcel that referenced this issue Jul 31, 2020
Add unit tests and update the change log for the PR pyexcel#214
chfw pushed a commit that referenced this issue Jul 31, 2020
Add unit tests and update the change log for the PR #214
@chfw chfw mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants