Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the interplay between TUDataset and pre_transform that modify node features #4669

Merged
merged 3 commits into from May 17, 2022
Merged

Fix the interplay between TUDataset and pre_transform that modify node features #4669

merged 3 commits into from May 17, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented May 17, 2022

No description provided.

@rusty1s rusty1s changed the title Fix the interplace between TUDataset and pre_transform that modify node features Fix the interplay between TUDataset and pre_transform that modify node features May 17, 2022
@rusty1s rusty1s self-assigned this May 17, 2022
@rusty1s rusty1s linked an issue May 17, 2022 that may be closed by this pull request
pre_transform works not as expected #4663
Closed
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited

Codecov Report

Merging #4669 (81f3b80) into master (6156650) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4669   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         318      318           
  Lines       16813    16817    +4     
=======================================
+ Hits        13935    13939    +4     
  Misses       2878     2878
Impacted Files Coverage Δ
torch_geometric/io/tu.py 93.90% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6156650...81f3b80. Read the comment docs.

@rusty1s rusty1s mentioned this pull request May 17, 2022
Closed
@rusty1s rusty1s merged commit be2a463 into master May 17, 2022
@rusty1s rusty1s deleted the fix_tu_num_node_attrs branch May 17, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre_transform works not as expected
1 participant
@rusty1s