Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: unicode argument expected, got 'str' #18

Closed
utensil opened this issue Mar 2, 2019 · 1 comment · Fixed by #17
Assignees
Milestone

Comments

@utensil
Copy link
Member

@utensil utensil commented Mar 2, 2019

As reported by @FreddyBaudine here and discussed here, it seems that the usages of StringIO should be replaced by BytesIO.

The work needs to be done:

  • Reproduce by tests: possibly a test_py2_compat.py since most tests are written in Python 3 flavor
  • Identify the root cause and best practice
  • Fix it and pass tests
@utensil utensil self-assigned this Mar 2, 2019
This was referenced Mar 4, 2019
utensil added a commit that referenced this issue Mar 12, 2019
@utensil

This comment has been minimized.

Copy link
Member Author

@utensil utensil commented Mar 16, 2019

c4f0003 was an attempt of fixing this under Python 2 but it fails under Python 3.

utensil added a commit that referenced this issue Mar 16, 2019
@utensil utensil added this to the 0.4.4 milestone Apr 3, 2019
@utensil utensil closed this in #17 Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.