Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit from everything without a shebang #46

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Oct 17, 2019

If it doesn't have a shebang and isn't bash or a binary, it shouldn't be marked as executable

Performed using git ls-files | xargs -d '\n' git update-index --chmod=-x, and then manually removing the three files with a shebang.


This probably crept in from someone using a linux filesystem on windows.

If it doesn't have a shebang and isn't bash or a binary, it shouldn't be marked as executable

Performed using `git ls-files | xargs -d '\n' git update-index --chmod=-x`, and then manually removing the three files with a shebang
@utensil

This comment has been minimized.

Copy link
Member

utensil commented Oct 17, 2019

LGTM.

@utensil

This comment has been minimized.

Copy link
Member

utensil commented Oct 17, 2019

Please merge at will when the build finishes. Thanks for helping out!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files           8        8           
  Lines        4898     4898           
=======================================
  Hits         3258     3258           
  Misses       1640     1640
Impacted Files Coverage Δ
galgebra/__init__.py 100% <ø> (ø) ⬆️
galgebra/lt.py 43.09% <ø> (ø) ⬆️
galgebra/printer.py 77.34% <ø> (ø) ⬆️
galgebra/ga.py 74.32% <ø> (ø) ⬆️
galgebra/metric.py 70.53% <ø> (ø) ⬆️
galgebra/mv.py 61.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c644116...be254ad. Read the comment docs.

@eric-wieser eric-wieser merged commit d25ec40 into pygae:master Oct 17, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing c644116...be254ad
Details
codecov/project 66.51% remains the same compared to c644116
Details
@eric-wieser eric-wieser deleted the eric-wieser:fix-file-permissions branch Nov 29, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.