Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docstring of `metric` to render properly #50

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 12, 2019

This uses the numpy docstring style, which is already enabled in the sphinx config

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files           8        8           
  Lines        4906     4906           
=======================================
  Hits         3266     3266           
  Misses       1640     1640
Impacted Files Coverage Δ
galgebra/metric.py 71.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1aaaa...99c5806. Read the comment docs.

@eric-wieser eric-wieser marked this pull request as ready for review Nov 12, 2019
@eric-wieser eric-wieser reopened this Nov 14, 2019
This uses the numpy docstring style, which is already enabled in the sphinx config
@eric-wieser eric-wieser force-pushed the eric-wieser:fix-docstrings branch from 565faf2 to 99c5806 Nov 14, 2019
@eric-wieser eric-wieser requested a review from utensil Nov 14, 2019
@utensil utensil merged commit a1ad518 into pygae:master Nov 14, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
codecov/patch 100% of diff hit (target 66.57%)
Details
codecov/project 66.57% (+0%) compared to ea1aaaa
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.