Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy `Mv.make_x` methods #58

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 20, 2019

Extracted from gh-57 to make the diff there readable

`f(*(a, b), c)` is just a weird way to spell `f(a, b, c)`.
def make_grade(self, *args, **kwargs):
# Called by __init__ to make a pure grade multivector.

# Called by __init__ to make a pure grade multivector.
Comment on lines 179 to +180

This comment has been minimized.

Copy link
@eric-wieser

eric-wieser Nov 20, 2019

Author Contributor

github struggles to diff with these unindented comments

This comment has been minimized.

Copy link
@waldyrious

waldyrious Nov 20, 2019

Contributor

Viewing the diff in ignore-whitespace mode (?w=1) helps.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #58 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   66.57%   66.54%   -0.03%     
==========================================
  Files           8        8              
  Lines        4906     4899       -7     
==========================================
- Hits         3266     3260       -6     
+ Misses       1640     1639       -1
Impacted Files Coverage Δ
galgebra/mv.py 61.52% <83.33%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7f524...4918d51. Read the comment docs.

Strips leading blank lines, no-op returns, and indents comments
@eric-wieser eric-wieser force-pushed the eric-wieser:tidy-mv-make-methods branch from 1d712c1 to e1b68f1 Nov 20, 2019
@eric-wieser eric-wieser changed the title Tidy `Mv.make_x` methods Tidy `Mv.make_x` methods and make them private Nov 20, 2019
@eric-wieser eric-wieser force-pushed the eric-wieser:tidy-mv-make-methods branch from e1b68f1 to 4918d51 Nov 20, 2019
@utensil

This comment has been minimized.

Copy link
Member

utensil commented Nov 20, 2019

LGTM.

@utensil utensil merged commit 552600e into pygae:master Nov 20, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat 1 issue resolved and 1 introduced
Details
codecov/patch 83.33% of diff hit (target 66.57%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +16.76% compared to 4d7f524
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@eric-wieser eric-wieser changed the title Tidy `Mv.make_x` methods and make them private Tidy `Mv.make_x` methods Nov 27, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.