Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the `Mv.make_x` functions private #59
Conversation
These are not documented or used anywhere outside of __init__. Nor are they useful, since the caller can just construct themselves a new `Mv` instead of reusing the old one. Now that they are private, we can convert these comments into docstrings without them appearing on readthedocs.
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 20, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 8 8
Lines 4899 4899
=======================================
Hits 3260 3260
Misses 1639 1639
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric-wieser commentedNov 20, 2019
•
edited
These are not documented or used anywhere outside of init.
Nor are they useful, since the caller can just construct themselves a new
Mvinstead of reusing the old one.Now that they are private, we can convert these comments into docstrings without them appearing on readthedocs.
Also split from #57