Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the `Mv.make_x` functions private #59

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 20, 2019

These are not documented or used anywhere outside of init.
Nor are they useful, since the caller can just construct themselves a new Mv instead of reusing the old one.

Now that they are private, we can convert these comments into docstrings without them appearing on readthedocs.

Also split from #57

These are not documented or used anywhere outside of __init__.
Nor are they useful, since the caller can just construct themselves a new `Mv` instead of reusing the old one.

Now that they are private, we can convert these comments into docstrings without them appearing on readthedocs.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files           8        8           
  Lines        4899     4899           
=======================================
  Hits         3260     3260           
  Misses       1639     1639
Impacted Files Coverage Δ
galgebra/mv.py 61.52% <88.88%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552600e...6d50440. Read the comment docs.

@utensil utensil merged commit 6d50440 into pygae:master Nov 21, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat 5 issues resolved and 5 introduced
Details
codecov/patch 88.88% of diff hit (target 66.54%)
Details
codecov/project 66.54% (+0%) compared to 552600e
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.