Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `blade_rep` and `base_rep` non mutating #60
Conversation
Previously this would cause weird and surprising swaps between basis representations.
self = self.blade_rep() | ||
A = A.blade_rep() |
Comment on lines
-513
to
-514
Beta
Send feedback
This comment has been minimized.
This comment has been minimized.
eric-wieser
Nov 21, 2019
Author
Contributor
Now that these don't mutate state, there is no need to try and undo the swap between representations
This comment has been minimized.
This comment has been minimized.
eric-wieser
Nov 21, 2019
•
Author
Contributor
There are other places in this file that simply did not swap between representations, which is what motivated the change
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 66.54% 66.61% +0.07%
==========================================
Files 8 8
Lines 4899 4895 -4
==========================================
+ Hits 3260 3261 +1
+ Misses 1639 1634 -5
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Thank you for fixing this and the coverage increased a bit too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric-wieser commentedNov 21, 2019
Previously this would cause weird and surprising swaps between basis representations.