Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `blade_rep` and `base_rep` non mutating #60

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 21, 2019

Previously this would cause weird and surprising swaps between basis representations.

Previously this would cause weird and surprising swaps between basis representations.
@eric-wieser eric-wieser added the bug label Nov 21, 2019
self = self.blade_rep()
A = A.blade_rep()
Comment on lines -513 to -514

This comment has been minimized.

Copy link
@eric-wieser

eric-wieser Nov 21, 2019

Author Contributor

Now that these don't mutate state, there is no need to try and undo the swap between representations

This comment has been minimized.

Copy link
@eric-wieser

eric-wieser Nov 21, 2019

Author Contributor

There are other places in this file that simply did not swap between representations, which is what motivated the change

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.07%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   66.54%   66.61%   +0.07%     
==========================================
  Files           8        8              
  Lines        4899     4895       -4     
==========================================
+ Hits         3260     3261       +1     
+ Misses       1639     1634       -5
Impacted Files Coverage Δ
galgebra/mv.py 61.79% <76.92%> (+0.27%) ⬆️
galgebra/utils.py 55.55% <0%> (-11.12%) ⬇️
galgebra/ga.py 74.39% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552600e...c370387. Read the comment docs.

@utensil

This comment has been minimized.

Copy link
Member

utensil commented Nov 21, 2019

Thank you for fixing this and the coverage increased a bit too. 👍

@utensil utensil merged commit 6bbfd33 into pygae:master Nov 21, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
codecov/patch 76.92% of diff hit (target 66.54%)
Details
codecov/project 66.61% (+0.07%) compared to 552600e
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@eric-wieser eric-wieser deleted the eric-wieser:pure-blade_rep branch Nov 26, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.