Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal caching and construction methods private #65

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 25, 2019

The user has no reason to ever call these methods - they're called at construction, and they have no return value.

Also makes some internal caching flags private - the user should be calling the function directly, rather than poking around in the cache.

@eric-wieser eric-wieser requested a review from utensil Nov 25, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 77.41%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #65   +/-   ##
======================================
  Coverage    66.7%   66.7%           
======================================
  Files           8       8           
  Lines        4890    4890           
======================================
  Hits         3262    3262           
  Misses       1628    1628
Impacted Files Coverage Δ
galgebra/metric.py 71.07% <100%> (ø) ⬆️
galgebra/ga.py 74.73% <74.07%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae058c...df784c3. Read the comment docs.

@eric-wieser eric-wieser force-pushed the eric-wieser:private-ga-methods branch from 7ece3eb to 8500496 Nov 25, 2019
The user has no reason to ever call these methods - they're called at construction, and they have no return value.

Also makes some internal caching flags private - the user should be calling the function directly, rather than poking around in the cache.
@eric-wieser eric-wieser force-pushed the eric-wieser:private-ga-methods branch from 8500496 to df784c3 Nov 26, 2019
@eric-wieser eric-wieser added this to Blocks further cleanup in Miscellaneous cleanup Nov 26, 2019
Copy link
Member

utensil left a comment

Always wanted to do this when I saw these methods.

@utensil utensil merged commit 6b8b2ee into pygae:master Nov 26, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat 14 issues resolved and 14 introduced
Details
codecov/patch 77.41% of diff hit (target 66.7%)
Details
codecov/project 66.7% (+0%) compared to 5ae058c
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Miscellaneous cleanup automation moved this from Blocks further cleanup to Closed Nov 26, 2019
@eric-wieser eric-wieser deleted the eric-wieser:private-ga-methods branch Nov 26, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.