Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up the multiplication table attributes on Ga #66
This: * Removes the always-empty: * `Ga.mul_table` * `Ga.wedge_table` * `Ga.dot_table` * `Ga.left_contract_table` * `Ga.right_contract_table` * Rewrites the unused `auto_update_dict` to be `lazy_dict`, which uses `dict.__missing__` for simplicity * Changes `Ga.mul_table_dict` and similar to be lazy, which is better than it starting off completely empty * Adds documentation for the other `Ga.*_table_dict` attributes * Removes the `func` argument from `update_and_substitute`, which is now usable with a dictionary alone. I don't think this is really public API, so this should be fine.
@@ Coverage Diff @@ ## master #66 +/- ## ========================================== + Coverage 66.7% 66.82% +0.11% ========================================== Files 8 8 Lines 4890 4883 -7 ========================================== + Hits 3262 3263 +1 + Misses 1628 1620 -8
utensil merged commit
Nov 26, 2019
5 checks passed
5 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.