Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent magic methods #67

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 25, 2019

__add_ab__ appeared in a very old python-dev discussion, but as far as I can tell has never been respected, and certainly is not respected in any supported version of python - the correct spelling is __iadd__.

Given that galgebra is working fine without these methods, and sympy does not define any in place operators, it seems wise to just remove them.

`__add_ab__` appeared in a very old `python-dev` discussion, but as far as I can tell has never been respected, and certainly is not respected in any supported version of python - the correct spelling is `__iadd__`.

Given that `galgebra` is working fine without these methods, and sympy does not define any in place operators, it seems wise to just remove them.
@eric-wieser eric-wieser requested a review from utensil Nov 25, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage    66.7%   67.19%   +0.48%     
==========================================
  Files           8        8              
  Lines        4890     4847      -43     
==========================================
- Hits         3262     3257       -5     
+ Misses       1628     1590      -38
Impacted Files Coverage Δ
galgebra/mv.py 62.97% <100%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae058c...eefb83c. Read the comment docs.

@eric-wieser eric-wieser added this to Low priority in Miscellaneous cleanup Nov 26, 2019
Copy link
Member

utensil left a comment

And I checked ganja.js generated python files also have no such operators.

@utensil utensil merged commit 6b8055b into pygae:master Nov 26, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat 2 issues resolved and 0 introduced
Details
codecov/patch 100% of diff hit (target 66.7%)
Details
codecov/project 67.19% (+0.48%) compared to 5ae058c
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Miscellaneous cleanup automation moved this from Low priority to Closed Nov 26, 2019
@eric-wieser eric-wieser deleted the eric-wieser:remove-fake-magic-method branch Nov 26, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.