Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify loops using `enumerate` and `range` #72

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 26, 2019

This saves a few lines, and makes the loops easier to reason about.

Also simplifies a call to itertools.product to reduce the length of a long line

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #72 into master will increase coverage by <.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #72      +/-   ##
=========================================
+ Coverage    66.7%   66.7%   +<.01%     
=========================================
  Files           8       8              
  Lines        4890    4878      -12     
=========================================
- Hits         3262    3254       -8     
+ Misses       1628    1624       -4
Impacted Files Coverage Δ
galgebra/lt.py 43.29% <0%> (+0.29%) ⬆️
galgebra/mv.py 61.65% <100%> (-0.05%) ⬇️
galgebra/ga.py 74.59% <100%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4bffb...2a1c9f0. Read the comment docs.

@eric-wieser eric-wieser added this to Low priority in Miscellaneous cleanup Nov 26, 2019
This saves a few lines, and makes the loops easier to reason about.

Also simplifies a call to `itertools.product` to reduce the length of a long line
@eric-wieser eric-wieser force-pushed the eric-wieser:iterator-methods branch from 2425060 to 2a1c9f0 Nov 26, 2019
Copy link
Member

utensil left a comment

Nice!

@utensil utensil merged commit 1ae503f into pygae:master Nov 26, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 44.44% of diff hit (target 66.7%)
Details
Travis CI - Pull Request Build Passed
Details
codebeat 2 issues resolved and 0 introduced
Details
codecov/project 66.7% (+<.01%) compared to ca4bffb
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Miscellaneous cleanup automation moved this from Low priority to Closed Nov 26, 2019
@eric-wieser eric-wieser deleted the eric-wieser:iterator-methods branch Nov 26, 2019
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.