Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for some key functions #361

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
2 participants
@mweb
Copy link
Contributor

mweb commented Oct 10, 2017

Add unit tests for:

key.get_mods
key.set_mods
key.get_repeat
key.set_repeat
key.name

I wanted to resolve #309 but since the SDL_GetKeyFromName is not available within SDL 1.2 I just added the unit tests that I started when I looked into the issues. I had no idea how to implement the tests for the other functions.

add unit test for some key functions
Add unit tests for:

key.get_mods
key.set_mods
key.get_repeat
key.set_repeat
key.name

@mweb mweb force-pushed the mweb:unittests_key branch from 312f458 to b663a84 Oct 11, 2017

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 29, 2017

Reopening to re-run tests.

@takluyver takluyver closed this Nov 29, 2017

@takluyver takluyver reopened this Nov 29, 2017

@takluyver takluyver closed this Nov 29, 2017

@takluyver takluyver reopened this Nov 29, 2017

@takluyver takluyver merged commit 20b1bec into pygame:master Nov 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.