Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygame.math.Vector2/3 not experimental #403

Merged
merged 14 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@illume
Copy link
Member

illume commented Feb 24, 2018

  • pickle/unpickle
  • swizzle on by default
  • speed up swizzle access.
  • swizzle returns a Vector2 or Vector3 if of length 2 or 3.
  • more tests, removed some DeprecationWarning in tests.
  • removed experimental notice.

@illume illume changed the title pygame.math.Vector2/3 can now pickle/unpickle. pygame.math.Vector2/3 not experimental Feb 25, 2018

@illume

This comment has been minimized.

Copy link
Member Author

illume commented Feb 27, 2018

I won't move pygame.math.Vector2/3 into pygame or pygame.locals namespace for now. That's potentially breaking things which already have their own Vector2/3. This type of API change will wait for a pygame2.

Narrative documentation is missing, but that will come in a separate PR.

@illume illume merged commit bf14d35 into master Feb 27, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@illume illume deleted the vectorpickle branch Feb 27, 2018

@bitcraft

This comment has been minimized.

Copy link
Member

bitcraft commented Feb 27, 2018

Thanks for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.