Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker vagrant install instructions for manylinux build. #469

Merged
merged 3 commits into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@illume
Copy link
Member

illume commented Jul 16, 2018

Updating instructions for manylinux build as I go. So far docker instructions changed since last year.

  • freetype pkg-config does not work, fallback to freetype-config.
  • update docker install instructions on vagrant.
  • upgrade manylinux to have python3.7 (cp37-cp37m)

re: #390

@illume illume changed the title Updated docker vagrant install instructions for manylinux build. WIP: Updated docker vagrant install instructions for manylinux build. Jul 16, 2018

@illume

This comment has been minimized.

Copy link
Member Author

illume commented Jul 16, 2018

Looks like this freetype pkg-config change broke the manylinux build: #442

    WARNING: "pkg-config freetype2" failed!

@illume illume force-pushed the manylinux-new-docker branch from 2497061 to 8450ac1 Jul 17, 2018

@illume

This comment has been minimized.

Copy link
Member Author

illume commented Jul 17, 2018

@takluyver do you remember how to upload an updated image to the docker hub? I had to do a make pull for the manylinux python 3.7

@illume illume changed the title WIP: Updated docker vagrant install instructions for manylinux build. Updated docker vagrant install instructions for manylinux build. Jul 17, 2018

@illume illume added this to the 1.9.4 milestone Jul 17, 2018

@illume illume merged commit 80a230f into master Jul 17, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jul 17, 2018

There's a make push target in the makefile which should do it. The actual commands it uses look like docker push pygame/manylinux1_base_x86_64 .

@illume

This comment has been minimized.

Copy link
Member Author

illume commented Jul 19, 2018

Ah ha! Thanks. I also had to do docker login, and the make push ran. Looks like https://hub.docker.com/u/pygame/ has the new images now.

@illume illume deleted the manylinux-new-docker branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.