Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform.scale does not crash for zero sized surfaces. #489

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@illume
Copy link
Member

illume commented Aug 16, 2018

Thanks for the unit test @augusto2112

  • This fixes #411
  • I made a mistake in the issue description for 411, as the transform.scale test should have been put into test/transform_test.py So I moved the test in there.

@illume illume merged commit 208bac5 into master Aug 16, 2018

1 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@illume illume deleted the issue-411-scale-crash branch Aug 16, 2018

@augusto2112

This comment has been minimized.

Copy link

augusto2112 commented Aug 16, 2018

You're welcome!

I was trying to get the C code to compile on the mac so I could fix the underlying issue, but I see you've done it already 😄

@illume

This comment has been minimized.

Copy link
Member Author

illume commented Aug 16, 2018

Oh, sorry about that! Did you get things to compile in the end? The instructions here should help. https://www.pygame.org/wiki/MacCompile Let me know if you have any issues, or if you want to get stuck into another C issue, let me know, and I can look for one for you?

@augusto2112

This comment has been minimized.

Copy link

augusto2112 commented Aug 16, 2018

No need to apologize!

I didn't manage to get it to compile yet, but I'm at work now so I'll continue trying tonight.

After I get it to run I'll let you know if I can't find an issue.

Thanks for all the help 😄

@illume illume referenced this pull request Oct 16, 2018

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.