Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for overlap mask #500

Merged
merged 2 commits into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@augusto2112
Copy link

augusto2112 commented Aug 22, 2018

Added a test for overlap mask that demonstrates at least one case where overlap mask currently fails.

augusto
@augusto2112

This comment has been minimized.

Copy link
Author

augusto2112 commented Aug 23, 2018

Issue: #410

@illume

This comment has been minimized.

Copy link
Member

illume commented Aug 23, 2018

Because it's a known failing test, can we please mark it with an ignore tag?

        """ |tags: ignore| 
        """ 

This way it still fails if we run python test/mask_test.py but it will pass on CI. Because it could take some time for the fix for the issue to be committed, we still want to be able to have the CI do builds and only fail if tests we know should pass fail.

augusto
@illume

This comment has been minimized.

Copy link
Member

illume commented Aug 23, 2018

Thanks @augusto2112 :)

@illume illume merged commit 80d70db into pygame:master Aug 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@illume illume referenced this pull request Oct 16, 2018

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.