Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi tests : add, refactor, cleanup #509

Merged
merged 15 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@e1000
Copy link

e1000 commented Aug 27, 2018

Hi, many new tests for midi:

  • the PR is a bit noisy, since I created two more test case classes MidiInputTest and MidiOutputTest, moving code around
  • add a lot of tests (no more def todo_test_sth left)
  • tried to get rid of the Exception: b"PortMidi: Invalid MIDI message Data'" messages during test run with setUp and tearDown (worked only partially)
  • cleanup using Python >= 2.7
  • also, I removed the __doc__ as of 2009 ... docstrings (noisy last commit to be possibly reverted)

I do not understand so much midi, and specially not understanding midi.midis2events ...

Note: I also tested pg.midi.Output.pitch_bend while going through source code, but it is not mentionned in https://www.pygame.org/docs/ref/midi.html ; ommitted or intended ?

@illume

This comment has been minimized.

Copy link
Member

illume commented Aug 28, 2018

This is awesome :) Thank you!

  • midis2events is for turning midi events into pygame events.
  • oh yes, there is no documentation for pg.midi.Output.pitch_bend. This would need to be added in docs/reST/ref/midi.rst

@illume illume merged commit eb7b2ed into pygame:master Aug 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illume illume referenced this pull request Oct 16, 2018

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.