Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odd-width ellipses not drawing correctly #511

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@LambdaGoblin
Copy link
Contributor

LambdaGoblin commented Aug 28, 2018

The solid and hollow ellipse functions are combined into a single
function that takes a center point, width and height instead of
two radii. The function is then able to draw to the appropriate
size.

For #233

LambdaGoblin added some commits Aug 28, 2018

Fixes 233, draw odd-width ellipses correctly.
The solid and hollow ellipse functions are combined into a single
function that takes a center point, width and height instead of
two radii.  The function is then able to draw to the appropriate
size.
@illume

This comment has been minimized.

Copy link
Member

illume commented Aug 28, 2018

Nice one. We can wait until #510 is merged in, and then see how this one goes with all the build machines testing it.

@illume illume changed the title Fix issue 233 Fix issue with odd-width ellipses not drawing correctly Aug 28, 2018

@illume illume changed the title Fix issue with odd-width ellipses not drawing correctly Fix odd-width ellipses not drawing correctly Aug 28, 2018

@illume illume merged commit 75ff0ac into pygame:master Aug 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illume illume referenced this pull request Oct 16, 2018

Closed

1.9.5 release notes. #561

4 of 4 tasks complete

@Earlo Earlo referenced this pull request Feb 8, 2019

Closed

pygame.draw.ellipse does not draw ellipses with odd sizes #233

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.