Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Python < 2.7 references #514

Merged
merged 4 commits into from Aug 30, 2018
Merged

Cleanup Python < 2.7 references #514

merged 4 commits into from Aug 30, 2018

Conversation

@e1000
Copy link

@e1000 e1000 commented Aug 29, 2018

Remove old code and comments for Python 2.2, 2.3, 2.5 ...

Since PR requests 504 & 509 implies we drop Python < 2.7 , it should be fine, isn't it?

@e1000
Copy link
Author

@e1000 e1000 commented Aug 29, 2018

Oh, I'm newbie to Python-C API, but if I understand right, I could cleanup much more C-code watching out for PY_VERSION_HEX < 0x02070000, right ?

Should I give it a try, or another branch?

@illume
Copy link
Member

@illume illume commented Aug 29, 2018

Hello! Yes, I think this should be fine :)

Feel free to keep going in this branch?

@Earlo
Copy link

@Earlo Earlo commented Aug 29, 2018

Kind of pointless comment but please refer to PRs with #504 and #509 in github. it makes it much easier to follow the conversation. @e1000

Regards Your friendly neighbourhood repository lurker

@illume illume merged commit 71082fb into pygame:master Aug 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@illume illume mentioned this pull request Oct 16, 2018
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants