Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile for PyPy 3 and PyPy fixes #663

Merged
merged 4 commits into from Dec 7, 2018
Merged

Compile for PyPy 3 and PyPy fixes #663

merged 4 commits into from Dec 7, 2018

Conversation

@dlon
Copy link
Member

@dlon dlon commented Dec 4, 2018

I also enabled FreeType (but had to avoid using the module state). Rect seems to be broken.

@dlon dlon modified the milestones: 1.9.5, pypy Dec 4, 2018
@illume
Copy link
Member

@illume illume commented Dec 7, 2018

Very nice :)

Hi. I tried it with pypy 5.10.0 from homebrew mac, and got this error.

    import pygame.font
ImportError: unable to load extension module '/usr/local/Cellar/pypy/5.10.0_1/libexec/site-packages/pygame/font.pypy-41.so': dlopen(/usr/local/Cellar/pypy/5.10.0_1/libexec/site-packages/pygame/font.pypy-41.so, 6): Symbol not found: _PyUnicode_AsUTF16String

However, because 5.10.0 has quite a few errors in CPython API extension support it's ok to require pypy 6.0+ If you agree, let's merge this in? (also added supported pypy version to README).

pypy - 1 failure, 8 errors in the rect module.

On pypy3 6.0.0 mac homebrew I get this:

loading test.mouse_test
loading test.overlay_test
loading test.pixelarray_test
pypy3(97323,0x7fff898c4380) malloc: *** error for object 0x7fc4de0bb3c0: incorrect checksum for freed object - object was probably modified after being freed.
*** set a breakpoint in malloc_error_break to debug
Abort trap: 6

I skipped pixelarray_test:PixelArrayTypeTest.test_contains and the test suite runs with the tests again same as pypy (failures=1, errors=8).

@dlon
Copy link
Member Author

@dlon dlon commented Dec 7, 2018

I agree with that.

@dlon dlon merged commit de193e8 into master Dec 7, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dlon dlon deleted the pypy branch Dec 7, 2018
@dlon dlon mentioned this pull request Mar 23, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants