Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread tests #707

Merged
merged 6 commits into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@dlon
Copy link
Member

dlon commented Jan 1, 2019

Test: Load image on multiple threads.
Test: Load music from file-like objects.

Loading music from threads (whether file objects or paths) seems to fail.

#704

Test: Load image on multiple threads.
Test: Load music from file-like objects.
@illume's issue: #704

@dlon dlon requested a review from illume Jan 1, 2019

@illume illume force-pushed the thread-tests branch from b21c45a to 19c2b2d Jan 5, 2019

@illume

This comment has been minimized.

Copy link
Member

illume commented Jan 5, 2019

I was able to come up with a test case that reliably crashes image loading in threads.

I'm not sure which image loading function(s) crash yet.
Probably the test case should be changed to be per extension.

Also, I didn't make it load images with python file objects.

@dlon

This comment has been minimized.

Copy link
Member Author

dlon commented Jan 10, 2019

It's a problem with GIFs in SDL_image. IMG_gif.c isn't thread-safe. The other three formats work fine. I submitted a patch, so hopefully it will be fixed in SDL at some point.

@dlon dlon force-pushed the thread-tests branch from 76d29b9 to 0a3d216 Jan 10, 2019

@dlon dlon merged commit 5b2b614 into master Jan 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dlon dlon deleted the thread-tests branch Jan 20, 2019

@dlon dlon referenced this pull request Mar 23, 2019

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.