Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_init() to midi module #745

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
2 participants
@charlesej
Copy link
Contributor

charlesej commented Jan 17, 2019

This update adds a get_init() function to the midi module.

Overview of changes:

  • Add get_init() function to the midi module.
  • Add a test case to test the new functionality.
  • Update the midi documentation.

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit)
  • pygame: 1.9.5.dev0 at 3dd0a82
  • numpy: 1.15.4

Resolves the midi item of #616.

charlesej added some commits Jan 17, 2019

@charlesej

This comment has been minimized.

Copy link
Contributor Author

charlesej commented Jan 18, 2019

Made some changes to this PR.

  • Added code Markdown to midi doc.
  • Changed test code to reuse existing tests.

@illume illume merged commit 8df22eb into pygame:master Jan 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@illume

This comment has been minimized.

Copy link
Member

illume commented Jan 21, 2019

Thanks :)

@charlesej charlesej deleted the charlesej:add-midi-get-init branch Jan 21, 2019

@dlon dlon referenced this pull request Mar 23, 2019

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.