Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aaline()/aalines() not drawing on a surface's border #802

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@charlesej
Copy link
Contributor

charlesej commented Feb 7, 2019

This update fixes aaline()/aalines() not drawing on a surface's border.

Overview of changes:

  • Changed the aaline draw code to clip using the correct surface size, to prevent it from drawing outside the surface's bounds, and to use the correct brightness.
  • Removed the @unittest.expectedFailure decorators (and the ignore tag) as these tests are now passing.

Notes:

  • Issue #801 has been opened to track some aaline related issues with draw_py.py.

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit)
  • pygame: 1.9.5.dev0 (SDL: 1.2.15) at ae1226c

Resolves #512 and resolves #732.

@illume illume merged commit 0e32989 into pygame:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@charlesej charlesej deleted the charlesej:fix-aaline-border-draw branch Feb 12, 2019

@dlon dlon referenced this pull request Mar 23, 2019

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.