Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for manylinux builds. #926

Merged
merged 5 commits into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@illume
Copy link
Member

illume commented Mar 23, 2019

I started updating the dependencies for the manylinux builds.

  • work out sha512 sums for all the downloads.
  • make a new docker image and test it.
  • do some testing of whl files.

@illume illume changed the title Start updating dependency versions for manylinux. WIP: Start updating dependency versions for manylinux. Mar 23, 2019

@illume illume force-pushed the manylinux-201903 branch from 3edca99 to f2c2d1e Mar 24, 2019

@illume illume merged commit 4b96bb2 into master Mar 24, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illume illume changed the title WIP: Start updating dependency versions for manylinux. Update dependencies for manylinux. Mar 24, 2019

@illume illume deleted the manylinux-201903 branch Mar 24, 2019

@illume illume changed the title Update dependencies for manylinux. Update dependencies for manylinux builds. Mar 31, 2019

@illume illume referenced this pull request Mar 31, 2019

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
ENV RPMFORGE_FILE "rpmforge-release-0.5.3-1.el5.rf.x86_64.rpm"
ADD "https://repoforge.cu.be/redhat/el5/en/x86_64/dag/RPMS/${RPMFORGE_FILE}" /tmp/${RPMFORGE_FILE}
#ENV RPMFORGE_FILE "rpmforge-release-0.5.3-1.el5.rf.x86_64.rpm"
#ADD "https://repoforge.cu.be/redhat/el5/en/x86_64/dag/RPMS/${RPMFORGE_FILE}" /tmp/${RPMFORGE_FILE}

This comment has been minimized.

Copy link
@takluyver

takluyver Apr 12, 2019

Member

Without repoforge, it looks like it's unable to find smpeg-devel (which SDL_mixer builds against), or pulseaudio-libs-devel (which fluidsynth and possibly SDL build against). Was that intentional?

Smpeg looks like it's unmaintained, so maybe it makes sense to drop it. Not supporting Pulseaudio might be more problematic, though I don't really know all the different pathways for sound on Linux. But I'm just looking at building with manylinux2010, and that seems to have pulseaudio-libs-devel anyway.

This comment has been minimized.

Copy link
@notpygame

notpygame Apr 12, 2019

Contributor

I'm sort of surprised we didn't have a test for mp3 loading.

smpeg is pretty bad at what it does, and yes unmaintained outside of the various random distro patches. It was unintentional to leave it out.

@llindstrom made this patch which uses libmpg123 for sdl_mixer 1.2. https://bitbucket.org/llindstrom/sdl_mixer-1.2-patches/overview However, I guess we should use smpeg still for this just because we know how it's bad, and the other platforms are using smpeg anyway.

There were lots of issues with fluidsynth and alsa/pulse using 100% CPU. They haven't been investigated fully. It was also unintentional to leave out pulseaudio-libs-devel. It would be interesting to see if the 100% cpu use is still there in the released 1.9.5 binary wheels. Or if the new manylinux2010 build solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.