Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDL_RWops instead of pg_FopenUTF8. #929

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
2 participants
@dlon
Copy link
Member

dlon commented Mar 24, 2019

This removes pg_FopenUTF8 in favor of SDL_RWFromFile. It was only used in imageext.c.

One issue is that the RWops API lacks a flush function, so I had to remove those. It seems to work fine without explicit flushing, though. SDL_image does more or less the same thing.

  • Manually test the image saving functions.
@illume

This comment has been minimized.

Copy link
Member

illume commented Mar 24, 2019

Cool. It's nice to get rid of all that code.

Without flushing, and fsync things will mostly work ok on local file systems with machines that aren't very loaded. When the machine is very busy, and file systems are remote or busy, that's when the issues start to come.

I guess the way forward is to try to get a flush call into SDL?

@illume

illume approved these changes Mar 24, 2019

@illume illume merged commit a84b461 into master Mar 24, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illume illume deleted the remove-pgopenutf8 branch Mar 24, 2019

@illume illume referenced this pull request Mar 31, 2019

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.