Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawing 1 pixel wide off-surface ellipses #931

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@charlesej
Copy link
Contributor

@charlesej charlesej commented Mar 25, 2019

This update fixes issues with drawing 1 pixel wide ellipses outside a given surface's bounds.

Overview of changes:

  • Added bounds check to drawvertlineclip
  • Fixed draw_ellipse's handling of special cases
  • Added several 1 pixel width/height ellipse tests

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit) and 2.7.10 (64bit)
  • pygame: 1.9.5.dev0 (SDL: 1.2.15) at a84b461

Resolves #913 and resolves #930.

- Added bounds check to drawvertlineclip
- Fixed draw_ellipse's handling of special cases
- Added several 1 pixel width/height ellipse tests
@notpygame notpygame merged commit be84f7a into pygame:master Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@charlesej charlesej deleted the charlesej:fix-ellipse-segfault branch Mar 28, 2019
@illume illume mentioned this pull request Mar 31, 2019
4 tasks done
@notpygame notpygame added the draw label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants