Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mask offset boundary checking consistent #937

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@charlesej
Copy link
Contributor

@charlesej charlesej commented Mar 26, 2019

Overview of changes:

  • Made the offset boundary checking consistent across bitmask functions
  • Added some offset boundary tests

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit) and 2.7.10 (64bit)
  • pygame: 1.9.5.dev1 (SDL: 1.2.15) at a84b461

Resolves the "Provide consistent boundary checking in bitmask.c" item of #800.

- Made the offset boundary checking consistent across bitmask functions
- Added some offset boundary tests
@notpygame notpygame merged commit 37eac56 into pygame:master Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@charlesej charlesej deleted the charlesej:update-mask-boundary-checks branch Mar 28, 2019
@illume illume mentioned this pull request Mar 31, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants