Skip to content

Conversation

@berendkleinhaneveld
Copy link
Contributor

This makes sure that on other platforms than Windows any available backend is picked.

@Korijn
Copy link
Collaborator

Korijn commented Jun 11, 2021

Is the Metal backend mature enough for usage yet?

@almarklein
Copy link
Member

Is the Metal backend mature enough for usage yet?

I guess Berend will find out :)

@Korijn
Copy link
Collaborator

Korijn commented Jun 11, 2021

As discussed: let's only force a backend if a certain envvar is given

@Korijn Korijn changed the title Force Vulkan only on Windows Force backend by WGPU_BACKEND_TYPE env var Jun 11, 2021
@Korijn
Copy link
Collaborator

Korijn commented Jun 11, 2021

LGTM!

@almarklein
Copy link
Member

almarklein commented Jun 11, 2021

I would expect this to make the CI fail, but I forgot that I had simply disabled all render-tests on CI. With this change, there are some tests running on CI (e.g. juggling with buffers and textures) which were previously skipped :)

@almarklein almarklein merged commit 96d49f4 into pygfx:main Jun 11, 2021
@berendkleinhaneveld berendkleinhaneveld deleted the force-vulkan-only-on-windows branch June 11, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants