Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unexport" isn't recognized as a Makefile keyword #1860

Closed
egor-tensin opened this issue Jul 13, 2021 · 0 comments · Fixed by #1898
Closed

"unexport" isn't recognized as a Makefile keyword #1860

egor-tensin opened this issue Jul 13, 2021 · 0 comments · Fixed by #1898
Labels
A-lexing area: changes to individual lexers good first issue Good for newcomers help wanted Community help appreciated!

Comments

@egor-tensin
Copy link

Title, basically. unexport (in contrast to export) isn't recognized as a Makefile keyword, although it is. I assume something here needs to be modified:

(r'(export)(\s+)(?=[\w${}\t -]+\n)',
.

@Anteru Anteru added good first issue Good for newcomers help wanted Community help appreciated! A-lexing area: changes to individual lexers labels Jul 18, 2021
blu-base added a commit to blu-base/pygments that referenced this issue Sep 25, 2021
As pointed out by Issue pygments#1860 the keyword unexport was not correctly
matched. Only the part `export' had been matched.

This commit adds an optional group to the regex of the `export`
keyword to match `unexport` as well.
Anteru pushed a commit that referenced this issue Oct 7, 2021
As pointed out by Issue #1860 the keyword unexport was not correctly
matched. Only the part `export' had been matched.

This commit adds an optional group to the regex of the `export`
keyword to match `unexport` as well.
@Anteru Anteru linked a pull request Oct 7, 2021 that will close this issue
@Anteru Anteru closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lexing area: changes to individual lexers good first issue Good for newcomers help wanted Community help appreciated!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants