Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Notmuch lexer #1264

Merged
merged 1 commit into from Nov 26, 2019
Merged

Add Notmuch lexer #1264

merged 1 commit into from Nov 26, 2019

Conversation

cpixl
Copy link
Contributor

@cpixl cpixl commented Nov 24, 2019

No description provided.

Anteru
Anteru requested changes Nov 24, 2019
View reviewed changes
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new lexer! Can you please provide some simple example file so we can ensure it works?

pygments/lexers/textfmts.py Show resolved Hide resolved
@cpixl
Copy link
Contributor Author

cpixl commented Nov 24, 2019

Thanks for the new lexer! Can you please provide some simple example file so we can ensure it works?

Ooops, I forgot to commit the example file! it's there now :)

@cpixl cpixl requested a review from Anteru November 24, 2019 17:47
birkenfeld
birkenfeld reviewed Nov 24, 2019
View reviewed changes
pygments/lexers/textfmts.py Outdated Show resolved Hide resolved
pygments/lexers/textfmts.py Outdated Show resolved Hide resolved
birkenfeld
birkenfeld requested changes Nov 25, 2019
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comments)

birkenfeld
birkenfeld approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@birkenfeld birkenfeld merged commit 176f1ac into pygments:master Nov 26, 2019
@cpixl cpixl deleted the notmuch-lexer branch November 27, 2019 21:01
birkenfeld pushed a commit that referenced this pull request Nov 28, 2019
@ashsearle @birkenfeld
Fix issue #1264: tweak patterns for regex and double-quoted strings f…
6dbbae5 
…or performance, avoiding slow back-tracking
birkenfeld pushed a commit that referenced this pull request Nov 29, 2019
@ashsearle @birkenfeld
Fix issue #1264: tweak patterns for regex and double-quoted strings f…
48e5505 
…or performance, avoiding slow back-tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld approved these changes

@Anteru Anteru Awaiting requested review from Anteru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpixl @birkenfeld @Anteru