Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "friendly grayscale" theme #1273

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Nov 24, 2019

This adds the style "friendly grayscale". It is based on the friendly style. The values were converted using the luminance values manually.

I need it for a PDF document looking the "similar" on the screen that on grayscale printing.

GitHub variant of https://bitbucket.org/birkenfeld/pygments-main/pull-requests/748/add-style-friendly-grayscale

Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, then we're good to go! This also fixes #1040 I assume? In that case please put "Fixes #1040" in the commit message.

pygments/styles/__init__.py Outdated Show resolved Hide resolved
pygments/styles/friendly_grayscale.py Outdated Show resolved Hide resolved
pygments/styles/friendly_grayscale.py Outdated Show resolved Hide resolved
:copyright: Copyright 2006-2017 by the Pygments team, see AUTHORS.
:license: BSD, see LICENSE for details.

! Name.Attribute is set to black because of https://github.com/gpoore/minted/issues/103
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we fix that bug instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, I don't feel empowered to fix that issue. I use the real value and put on my todo list to open an issue here (extracting the "best of" of gpoore/minted#103).

@koppor
Copy link
Contributor Author

koppor commented Dec 22, 2019

7 successful checks 🎉. Not sure about the AUTHORS file, because my contribution is rather minor.

@Anteru
Copy link
Collaborator

Anteru commented Jan 12, 2020

@birkenfeld Anything left to do here?

@koppor
Copy link
Contributor Author

koppor commented Mar 16, 2020

@birkenfeld May I ask for approval?

Fixes #1040.

@Raymo111
Copy link

Can we get this merged please?

@Anteru Anteru merged commit f7f5f94 into pygments:master Dec 28, 2021
@koppor koppor deleted the add-friendly-grayscale branch November 19, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants