Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 971: tweak patterns for regex and double-quoted strings f… #1312

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix issue 971: tweak patterns for regex and double-quoted strings f… #1312

merged 1 commit into from
Nov 29, 2019

Conversation

birkenfeld
Copy link
Member

…or performance, avoiding slow back-tracking

Ported from https://bitbucket.org/birkenfeld/pygments-main/pull-requests/660

Anteru
Anteru approved these changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, question is whether the TODO can be removed as well.

@birkenfeld
Copy link
Member Author

No, it still looks for '/' as the start...

@birkenfeld birkenfeld merged commit 48e5505 into master Nov 29, 2019
@birkenfeld birkenfeld deleted the 660/ashsearle/vimbacktrack branch November 29, 2019 04:54
@birkenfeld birkenfeld mentioned this pull request Nov 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anteru Anteru Anteru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birkenfeld @Anteru @ashsearle