Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: overhaul, cover more builtins and newer syntax #1320

Merged
merged 2 commits into from
Dec 1, 2019
Merged

Conversation

birkenfeld
Copy link
Member

No description provided.

Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not a rust user, so I'm not sure what those macro rules were and if that's going to cause failures on old code.

@birkenfeld
Copy link
Member Author

birkenfeld commented Dec 1, 2019

I'm not sure if the macro rules were meant to catch macro definitions or calls, since the rule isn't correct for either one. In any case, they never fired because the initial [A-z]\w+ would have been detected as a Name first.

And it's a good thing, because in the macro* states, only braces would have been allowed which doesn't make sense.

@birkenfeld birkenfeld merged commit b996622 into master Dec 1, 2019
@birkenfeld birkenfeld deleted the rust branch December 1, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants