Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D: remove typedef from keywords #1362

Merged
merged 1 commit into from Feb 29, 2020
Merged

D: remove typedef from keywords #1362

merged 1 commit into from Feb 29, 2020

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Jan 17, 2020

@Anteru
Copy link
Collaborator

Anteru commented Jan 17, 2020

Hi, can you please elaborate a bit? It's still a valid keyword, just deprecated, should we really stop highlighting it or maybe move it to a new class of deprecated keyword or something? This way you could highlight it in a different way if really needed, but all existing code would continue to get highlighted correctly.

@Anteru Anteru self-assigned this Jan 17, 2020
@kubo39
Copy link
Contributor Author

kubo39 commented Jan 18, 2020

Hi! typdef keyword was completely removed in dmd 2.072, please check the top of [this url].(https://dlang.org/deprecate.html)(I agree that the page title is confusing.)

@Anteru
Copy link
Collaborator

Anteru commented Jan 26, 2020

I see. The reason I'm not super comfortable with removing it wholesale is that old code can use it, and it should remain highlighted correctly. That's why I think using a new class like Keyword.Deprecated and Keyword.Removed is better than just removing it. Any thoughts?

@kubo39
Copy link
Contributor Author

kubo39 commented Jan 26, 2020

Looks good, should I close this issue?

@Anteru
Copy link
Collaborator

Anteru commented Jan 27, 2020

No, I'll close it once I fix it :)

@Anteru Anteru merged commit 5faf4c6 into pygments:master Feb 29, 2020
@kubo39 kubo39 deleted the dlang-remove-typedef-from-keywords branch February 29, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants