Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReasonML lexer. #1386

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Add ReasonML lexer. #1386

merged 1 commit into from
Feb 29, 2020

Conversation

fhammerschmidt
Copy link
Contributor

This implements #1355

I derived the ReasonML lexer from the OCaml one, since the former language is based on the latter, which turned out relatively good.

I added a testfile "test.re", too if you want to see for yourself.

Thanks in advance!

Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please add it to the language list in the documentation as well, make sure to provide a link, and then we should be good to go.

pygments/lexers/ml.py Outdated Show resolved Hide resolved
pygments/lexers/ml.py Outdated Show resolved Hide resolved
@jordwalke
Copy link

Thanks @fhammerschmidt !

@Anteru Anteru merged commit 0922530 into pygments:master Feb 29, 2020
@fhammerschmidt fhammerschmidt deleted the reasonml branch February 29, 2020 23:14
@montogeek
Copy link

@fhammerschmidt Do you have a plan to do the same for ReScript?

@fhammerschmidt
Copy link
Contributor Author

fhammerschmidt commented Feb 16, 2021

@fhammerschmidt Do you have a plan to do the same for ReScript?

Yeah, I could do that.
But it may be wiser to do it when more of the syntax has settled (like local opens, Infix, module imports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants