Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a filter for math symbols #1406

Merged
merged 2 commits into from
Apr 13, 2020
Merged

a filter for math symbols #1406

merged 2 commits into from
Apr 13, 2020

Conversation

lsf37
Copy link
Contributor

@lsf37 lsf37 commented Mar 4, 2020

This filer replaces math symbols from e.g. LaTeX and Isabelle with
corresponding unicode. It could be expanded to other math-heavy
languages.

(Ported from an existing bitbucket PR)

@lsf37
Copy link
Contributor Author

lsf37 commented Mar 4, 2020

Oops, failing tests. I guess things have moved on from then, will look into it.

@lsf37
Copy link
Contributor Author

lsf37 commented Mar 4, 2020

Ok, fixed.

@Anteru
Copy link
Collaborator

Anteru commented Apr 10, 2020

Can you please add a unit test for this, just to make sure there is some code calling it running during CI/CD?

@Anteru Anteru self-assigned this Apr 10, 2020
@lsf37
Copy link
Contributor Author

lsf37 commented Apr 10, 2020

Sure, will probably have a look tomorrow.

This filer replaces math symbols from e.g. LaTeX and Isabelle with
corresponding unicode. It could be expanded to other math-heavy
languages.
@lsf37
Copy link
Contributor Author

lsf37 commented Apr 13, 2020

Rebased and test added. I wasn't quite sure where exactly it should go. It's now together with the other filter tests, which seemed appropriate.

@Anteru
Copy link
Collaborator

Anteru commented Apr 13, 2020

Yep, that seems fine. I want to make sure that CI is covering this. Thanks!

@Anteru Anteru merged commit 74c1d80 into pygments:master Apr 13, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Apr 13, 2020
@Anteru Anteru added this to the 2.7 milestone Apr 13, 2020
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants