Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lexer for PsySH console for PHP #1438

Merged
merged 1 commit into from Sep 4, 2020
Merged

Add lexer for PsySH console for PHP #1438

merged 1 commit into from Sep 4, 2020

Conversation

ramsey
Copy link
Contributor

@ramsey ramsey commented May 1, 2020

This lexer is based on the PythonConsoleLexer and provides the ability
to highlight console input and output for PsySH, a developer console and
REPL for PHP. See https://psysh.org.

@ramsey ramsey changed the title Add lexer for Psysh console for PHP Add lexer for PsySH console for PHP May 1, 2020
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've got only one very minor request.

pygments/lexers/php.py Show resolved Hide resolved
@Anteru Anteru self-assigned this May 26, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label May 26, 2020
@Anteru Anteru added this to the 2.7 milestone May 26, 2020
This lexer is based on the PythonConsoleLexer and provides the ability
to highlight console input and output for PsySH, a developer console and
REPL for PHP. See https://psysh.org.
@ramsey
Copy link
Contributor Author

ramsey commented Sep 4, 2020

Following up to see if there are any other changes you'd like. Thanks!

@Anteru Anteru merged commit 91d4920 into pygments:master Sep 4, 2020
@Anteru
Copy link
Collaborator

Anteru commented Sep 4, 2020

Nope, all good -- thanks for the contribution!

@ramsey ramsey deleted the features/php-psysh-lexer branch September 4, 2020 16:10
@ramsey
Copy link
Contributor Author

ramsey commented Sep 4, 2020

Thanks!

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Sep 8, 2020
Kenny2github pushed a commit to Kenny2github/pygments that referenced this pull request Sep 22, 2020
This lexer is based on the PythonConsoleLexer and provides the ability
to highlight console input and output for PsySH, a developer console and
REPL for PHP. See https://psysh.org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants