Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SystemVerilog unit tests #1463

Merged
merged 1 commit into from May 27, 2020
Merged

Refactor SystemVerilog unit tests #1463

merged 1 commit into from May 27, 2020

Conversation

cjdrake
Copy link
Contributor

@cjdrake cjdrake commented May 27, 2020

Most of the contents of these two unit tests are static.
Move things around so the entire test fits on a single page,
for better readability/maintainability.

Name the code part <TEST_NAME>_TEXT,
and the tokens part <TEST_NAME>_TOKENS.

Choosing "text" b/c it's the parameter name to the
lexer.get_tokens(text) method.

Most of the contents of these two unit tests are static.
Move things around so the entire test fits on a single page,
for better readability/maintainability.

Name the code part <TEST_NAME>_TEXT,
and the tokens part <TEST_NAME>_TOKENS.

Choosing "text" b/c it's the parameter name to the
lexer.get_tokens(text) method.
@birkenfeld
Copy link
Member

Looks good!

@birkenfeld birkenfeld merged commit 9e1fa19 into pygments:master May 27, 2020
@cjdrake cjdrake deleted the refactor branch May 27, 2020 04:19
@Anteru Anteru self-assigned this May 27, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label May 27, 2020
@Anteru Anteru added this to the 2.7 milestone May 27, 2020
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants