Fix cmake header #1491
Merged
Fix cmake header #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Version number can have multiple digits. * Tabs are handled as white space. * Trailing comments are ignored.
This was referenced Jul 5, 2020
Anteru
requested changes
Aug 22, 2020
| r'^[ \t]*CMAKE_MINIMUM_REQUIRED[ \t]*' | ||
| r'\([ \t]*VERSION[ \t]*\d+(\.\d+)*[ \t]*' | ||
| r'([ \t]FATAL_ERROR)?[ \t]*\)[ \t]*' | ||
| r'(#[^\n]*)?$' |
There was a problem hiding this comment.
What is this last expression for? Consume an arbitrary number of comments? Is that really needed for the analysis?
There was a problem hiding this comment.
Can you please shed some more light on this?
There was a problem hiding this comment.
The intention is to ignore comments at the end of the line, e.g. in
cmake_minimum_required(version 3.13) # CMake version check
including an empty comment at the end of the line:
cmake_minimum_required(version 3.13) #
|
Thanks, merged! |
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
Kenny2github
pushed a commit
to Kenny2github/pygments
that referenced
this pull request
Sep 22, 2020
* Fixed guessing of CMake by header. * Version number can have multiple digits. * Tabs are handled as white space. * Trailing comments are ignored. * Cleaned up regex to detect CMake header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex to guess CMake by header has several flaws this patch fixes:
Reference: https://cmake.org/cmake/help/v3.13/manual/cmake-language.7.html#syntax