Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PromQL lexer #1506

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add a PromQL lexer #1506

merged 1 commit into from
Aug 19, 2020

Conversation

pabluk
Copy link
Contributor

@pabluk pabluk commented Aug 6, 2020

Hi,

I would like to contribute to the project with this PromQL lexer https://github.com/pabluk/pygments-promql that I wrote some days ago. It has documentation, several test cases and it's being used with no issues on a Sphinx documentation site.
By the way, PromQL it's the Prometheus Query Language https://prometheus.io/docs/prometheus/latest/querying/basics/.

I followed:

but please don't hesitate to request any changes you think could be appropriate or provide any feedback. Thanks.

@Anteru Anteru self-assigned this Aug 7, 2020
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only a few minor comments, if you could take a look that would be great!

pygments/lexers/promql.py Show resolved Hide resolved
pygments/lexers/promql.py Outdated Show resolved Hide resolved
pygments/lexers/promql.py Outdated Show resolved Hide resolved
Including tests and an example.promql file.
@pabluk
Copy link
Contributor Author

pabluk commented Aug 19, 2020

Thanks @Anteru for your suggestions and your time dedicated to review it. I applied all the changes required.

@Anteru Anteru merged commit 2124004 into pygments:master Aug 19, 2020
@Anteru
Copy link
Collaborator

Anteru commented Aug 19, 2020

Merged, thanks for your contribution!

@Anteru Anteru added this to the 2.7 milestone Aug 19, 2020
Kenny2github pushed a commit to Kenny2github/pygments that referenced this pull request Sep 22, 2020
Including tests and an example.promql file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants