Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix punctuation not labeled in function definition in TypeScript #1511

Merged
merged 3 commits into from Jan 4, 2021

Conversation

@felixhao28
Copy link
Contributor

@felixhao28 felixhao28 commented Aug 15, 2020

Fix #1510

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Aug 17, 2020

Thanks for the PR! Would you mind adding a small unit test for that?

@Anteru Anteru self-assigned this Aug 17, 2020
@Anteru Anteru added this to the 2.7 milestone Aug 17, 2020
@felixhao28
Copy link
Contributor Author

@felixhao28 felixhao28 commented Aug 18, 2020

The tests/test_javascript.py seems limited to CoffeeScript. I don't know if I should add another file for typescript tests.

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Aug 22, 2020

Yes, test_javascript would be the right place to put the test.

Copy link
Collaborator

@Anteru Anteru left a comment

Please add a unit test for this.

@felixhao28
Copy link
Contributor Author

@felixhao28 felixhao28 commented Aug 24, 2020

Test case added.

@Anteru Anteru removed this from the 2.7 milestone Sep 12, 2020
@Anteru Anteru added this to the 2.8 milestone Sep 12, 2020
tests/test_javascript.py Outdated Show resolved Hide resolved
Co-authored-by: Mestery <48163546+Mesteery@users.noreply.github.com>
@Anteru Anteru merged commit 5b432df into pygments:master Jan 4, 2021
@Anteru Anteru removed this from the 2.8 milestone Jan 4, 2021
@Anteru Anteru added this to the 2.7.4 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants