Update PostgreSQL builtins #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres source code locations and structure have changed a little. Also, now it works on Windows and sorts all keywords.
Note that LC_COLLATE and LCCTYPE are removed from the keywords list.
|
Thanks for the contribution. I may be blind, but where was the |
Anteru
added
the
changelog-update
|
Just a manual, local change while working on this. The error message was something like "email.parser is not a package", and that took a little bit of time to figure out.
I didn't rename the file in these commits but I wanted to point out that it may hamper update efforts in the future. =)
…On August 20, 2020 7:39:56 PM UTC, "Matthäus G. Chajdas" ***@***.***> wrote:
Thanks for the contribution. I may be blind, but where was the `email.py` file renamed? Or was this a one-time thing to get the script to run?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1513 (comment)
|
|
Makes sense, thanks! |
Anteru
removed
the
changelog-update
Kenny2github
pushed a commit
to Kenny2github/pygments
that referenced
this pull request
Sep 22, 2020
* Update the Postgres auto-update code Postgres source code locations and structure have changed a little. Also, now it works on Windows and sorts all keywords. * Update the PostgreSQL builtins Note that LC_COLLATE and LCCTYPE are removed from the keywords list. * Update AUTHORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing auto-update code no longer worked with current Postgres source code (or with Python 3.8), so I've updated that. I also encountered newline problems when running this on Windows and adjusted to fix that.
Note that the email lexer's filename prevents urllib from importing, so I had to rename
email.pyto get the code running. It may be worthwhile to rename the email lexer in the future.Please let me know if there's anything I'm missing with this. I read the contributing docs but didn't see anything about multiple commits so I tried to keep the history clean. I also ran the branch through tox but only on Python 3.8.
Thanks for any feedback you have!