Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prompt color for Solarized style. #1529

Merged
merged 3 commits into from Feb 7, 2021
Merged

Add missing prompt color for Solarized style. #1529

merged 3 commits into from Feb 7, 2021

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Sep 1, 2020

This might fix rendering on dark background as hinted by #1526.

@aroberge
Copy link

aroberge commented Sep 1, 2020

I think that the main Generic class should also have a color defined.

@Anteru Anteru self-assigned this Sep 2, 2020
@Anteru
Copy link
Collaborator

Anteru commented Sep 6, 2020

I agree with @aroberge -- I presume this does work for tracebacks, but it wouldn't hurt to have Generic in there as well. Could you please add that while you're at it?

Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plase add a color for Generic as well to have all bases covered. Otherwise looks good!

@Anteru Anteru added this to the 2.7 milestone Sep 6, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Sep 6, 2020
@Anteru Anteru modified the milestones: 2.7, 2.8 Sep 12, 2020
@kdeldycke
Copy link
Contributor Author

Sorry @Anteru for the delay. Just added the Generic style in d0ca1c8 .

This PR is ready to be merged! :)

Copy link
Contributor Author

@kdeldycke kdeldycke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Generic has been added: d0ca1c8

Copy link
Contributor Author

@kdeldycke kdeldycke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdeldycke kdeldycke requested a review from Anteru November 4, 2020 18:12
@Anteru Anteru merged commit a47dfa1 into pygments:master Feb 7, 2021
@Anteru
Copy link
Collaborator

Anteru commented Feb 7, 2021

Merged, thanks!

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Feb 7, 2021
@kdeldycke kdeldycke deleted the patch-1 branch February 7, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants