Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use yield from #1537

Merged
merged 1 commit into from
Sep 6, 2020
Merged

all: use yield from #1537

merged 1 commit into from
Sep 6, 2020

Conversation

birkenfeld
Copy link
Member

No description provided.

def get_tokens_unprocessed(self, text):
for index, token, value in \
RegexLexer.get_tokens_unprocessed(self, text):
yield index, token, value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed wholesale? I presume because that's equivalent to the parent class implementation?

Copy link
Member Author

@birkenfeld birkenfeld Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parent class is RegexLexer, AFAICS it just delegates everything to it.

Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I do have did have questions.

@Anteru Anteru merged commit 40baa94 into master Sep 6, 2020
@Anteru Anteru self-assigned this Sep 6, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Sep 6, 2020
@Anteru Anteru added this to the 2.7 milestone Sep 6, 2020
@Anteru Anteru deleted the yield-from branch September 6, 2020 12:35
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Sep 8, 2020
Kenny2github pushed a commit to Kenny2github/pygments that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants