Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RITA language #1541

Merged
merged 15 commits into from
Dec 28, 2021
Merged

Support for RITA language #1541

merged 15 commits into from
Dec 28, 2021

Conversation

zaibacu
Copy link
Contributor

@zaibacu zaibacu commented Sep 8, 2020

Introduces Lexer for RITA

Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've commented a few things to discuss.

pygments/lexers/rita.py Outdated Show resolved Hide resolved
pygments/lexers/rita.py Show resolved Hide resolved
pygments/lexers/rita.py Outdated Show resolved Hide resolved
@zaibacu
Copy link
Contributor Author

zaibacu commented Sep 10, 2020

Some times one of the builds freezes. Any ideas?

@Anteru
Copy link
Collaborator

Anteru commented Sep 11, 2020

I have to guess but I believe it's a randomized test hitting a regex which causes catastrophic backtracking. Can you try to run it locally with the same random seed: --randomly-seed=2266720041 and see if you get the same hang?

@zaibacu
Copy link
Contributor Author

zaibacu commented Sep 26, 2020

I have to guess but I believe it's a randomized test hitting a regex which causes catastrophic backtracking. Can you try to run it locally with the same random seed: --randomly-seed=2266720041 and see if you get the same hang?

Yes, thank you, can reproduce it with this seed and indeed it crashes on RitaLexer. Looking how to fix regex so it would not hang

@zaibacu
Copy link
Contributor Author

zaibacu commented May 31, 2021

Bump :) this one is still not merged

@Anteru Anteru merged commit 42b61e1 into pygments:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants