Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing turtle prefix names where reference starts with number #1590

Merged
merged 4 commits into from Dec 5, 2020

Conversation

@elf-pavlik
Copy link
Contributor

@elf-pavlik elf-pavlik commented Nov 2, 2020

closes #1553

I don't work with python myself but I hope changes here are reasonable. ShExC lexer handles prefixed names where part after : starts with number correctly. This change should only copy that part of ShExC lexer to Turtle lexer.

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Nov 2, 2020

Thanks for the contribution! Can you please take a look at the regexlint failures? It looks like some of your expression can be simplified.

@Anteru Anteru added this to the 2.7.3 milestone Nov 2, 2020
@elf-pavlik
Copy link
Contributor Author

@elf-pavlik elf-pavlik commented Nov 2, 2020

I did my best trying to align Turtle lexer with SPARQL and ShExC, not the other way. I also posted on RDFlib mailing list if some python developer familiar with RDF would consider helping with those RDF lexers: https://groups.google.com/g/rdflib-dev/c/hSGFT9jV61k

In my last commit I needed to fix example.ttl which wasn't valid turtle. Now it passes validation with http://ttl.summerofcode.be/

@elf-pavlik
Copy link
Contributor Author

@elf-pavlik elf-pavlik commented Nov 6, 2020

Please let me know if there's anything else I should do in this PR.

@Anteru Anteru merged commit 95935cc into pygments:master Dec 5, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants