Run pyupgrade across codebase to modernize syntax and patterns #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, except that the files in |
pyupgrade is a tool to automatically upgrade syntax for newer versions of the Python language. The project has been Python 3 only since 35544e2, allowing for several cleanups: - Remove unnecessary "-*- coding: utf-8 -*-" cookie. Python 3 reads all source files as utf-8 by default. - Replace IOError/EnvironmentError with OSError. Python 3 unified these exceptions. The old names are aliases only. - Use the Python 3 shorter super() syntax. - Remove "utf8" argument form encode/decode. In Python 3, this value is the default. - Remove "r" from open() calls. In Python 3, this value is the default. - Remove u prefix from Unicode strings. In Python 3, all strings are Unicode. - Replace io.open() with builtin open(). In Python 3, these functions are functionally equivalent.
|
Thanks for catching that. Fixed in the latest revision. |
Anteru
added
the
changelog-update
|
@birkenfeld Ready to merge assuming you're not hacking on things right now? |
|
Go ahead! |
Anteru
removed
the
changelog-update
|
I know this was a while ago, but I'd like to add that there was also a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyupgrade is a tool to automatically upgrade syntax for newer versions
of the Python language.
The project has been Python 3 only since
35544e2, allowing for several cleanups:
Remove unnecessary "-- coding: utf-8 --" cookie. Python 3 reads all
source files as utf-8 by default.
Replace IOError/EnvironmentError with OSError. Python 3 unified these
exceptions. The old names are aliases only.
Use the Python 3 shorter super() syntax.
Remove "utf8" argument form encode/decode. In Python 3, this value is
the default.
Remove "r" from open() calls. In Python 3, this value is the default.
Remove u prefix from Unicode strings. In Python 3, all strings are
Unicode.
Replace io.open() with builtin open(). In Python 3, these functions
are functionally equivalent.